Rob Bradford [Wed, 11 Jul 2012 13:37:46 +0000 (14:37 +0100)]
wayland: Protocol change: wl_shell_surface_* take surfaces for parents
These functions used to take shell_surface objects and now take surface
objects the parents.
Rob Bradford [Wed, 11 Jul 2012 13:37:04 +0000 (14:37 +0100)]
wayland: Remove unused variable
Rob Bradford [Wed, 11 Jul 2012 13:36:03 +0000 (14:36 +0100)]
wayland: Temporary disable/hackaround keyboard code
Rob Bradford [Wed, 11 Jul 2012 13:31:15 +0000 (14:31 +0100)]
wayland: Port to SHM pool allocation mechanism
Rob Bradford [Wed, 11 Jul 2012 13:29:43 +0000 (14:29 +0100)]
wayland: Port to new input protocol mechanism
This replaces the wl_input_device with wl_pointer, wl_keyboard, wl_touch all
tied together under a wl_seat.
This is quite a radical change in protocol and for now keyboard handling is
disabled.
Rob Bradford [Wed, 11 Jul 2012 13:18:28 +0000 (14:18 +0100)]
wayland: Load cursor theme using new Wayland cursor library
This requires the SHM object be initialised - therefore this is the most
logical (if slightly ugly place.)
We also need to make sure that we do something clever to load the correct
cursor theme.
Rob Bradford [Wed, 11 Jul 2012 13:17:36 +0000 (14:17 +0100)]
wayland: Remove unhelpful debug message
Rob Bradford [Wed, 11 Jul 2012 13:15:04 +0000 (14:15 +0100)]
wayland: Protocol change: ping event on shell_surface
Rob Bradford [Wed, 11 Jul 2012 13:12:07 +0000 (14:12 +0100)]
wayland: Update configure.ac to add now needed wayland-cursor
Rob Bradford [Mon, 18 Jun 2012 15:02:37 +0000 (16:02 +0100)]
wayland: Update to new header path for xkbcommon
Matthias Clasen [Thu, 12 Jul 2012 12:35:50 +0000 (08:35 -0400)]
Consistently allow -1 to mean 'append' in tree models
Both GtkListStore and GtkTreeStore had a few methods that allowed
-1 to mean 'append' when specified as a position, but others that
demanded positive position arguments. Make this consistent by
always allowing -1.
https://bugzilla.gnome.org/show_bug.cgi?id=667808
Emmanuele Bassi [Wed, 4 Jul 2012 10:41:50 +0000 (11:41 +0100)]
Ensure that XDG_DATA_HOME is created before using it
The recently-used.xbel storage for recently used files is located inside
the $XDG_DATA_HOME directory; there's no actual guarantee that the
directory has been created already, even though it's very highly
probable on any modern distribution. We should create it, along with its
intermediate parents, before constructing the file monitor that we use
to get change notifications.
https://bugzilla.gnome.org/show_bug.cgi?id=671817
https://bugzilla.gnome.org/show_bug.cgi?id=667808
Micah Carrick [Tue, 26 Jun 2012 03:21:22 +0000 (20:21 -0700)]
Fix typo replacing action "Parse" with "Paste"
The builder XML description has an action for "win.parse" but the
application is looking for "win.paste". Rename the label to
"_Paste" and the action to "win.paste" in the window action XML.
https://bugzilla.gnome.org/show_bug.cgi?id=678829
Phil Clayton [Sun, 1 Jul 2012 23:35:46 +0000 (00:35 +0100)]
Change signal parameter names in GdkWindow to be valid C identifiers
https://bugzilla.gnome.org/show_bug.cgi?id=679228
Matthias Clasen [Wed, 11 Jul 2012 11:15:34 +0000 (07:15 -0400)]
Revert "level-bar: introduce GtkLevelBar"
This reverts commit
126a2308ca467744178d4be3309403f6899de987.
Pushed by mistake.
Matthias Clasen [Wed, 11 Jul 2012 11:15:07 +0000 (07:15 -0400)]
Revert "visuals: add a visual demo for GtkLevelBar"
This reverts commit
ffdd7a5e185879006d405ffd69f68ff60f5fccfa.
Pushed by mistake.
Víctor Manuel Jáquez Leal [Wed, 4 Jul 2012 16:41:36 +0000 (18:41 +0200)]
docs: link against libgdk-3.la
https://bugzilla.gnome.org/show_bug.cgi?id=679409
Cosimo Cecchi [Fri, 8 Jun 2012 22:58:51 +0000 (18:58 -0400)]
visuals: add a visual demo for GtkLevelBar
https://bugzilla.gnome.org/show_bug.cgi?id=677892
https://bugzilla.gnome.org/show_bug.cgi?id=679409
Cosimo Cecchi [Tue, 29 May 2012 21:00:33 +0000 (17:00 -0400)]
level-bar: introduce GtkLevelBar
Similar to CcStrengthBar from gnome-control-center, but more generic and
with thorough CSS styling support.
https://bugzilla.gnome.org/show_bug.cgi?id=677892
Matthias Clasen [Wed, 11 Jul 2012 01:24:10 +0000 (21:24 -0400)]
GtkApplication: Fix unsetting menu models
Pointed out by Zachary Dovel in
http://bugzilla.gnome.org/show_bug.cgi?id=679705
Kjartan Maraas [Tue, 10 Jul 2012 13:17:06 +0000 (15:17 +0200)]
Updated Norwegian nynorsk translation
Matthias Clasen [Tue, 10 Jul 2012 02:12:45 +0000 (22:12 -0400)]
Silence the build
Hide gdbus-codegen behind $(AM_V_GEN) for silence and cleanliness.
Matthias Clasen [Tue, 26 Jun 2012 19:09:12 +0000 (15:09 -0400)]
Add missing functions to the docs
://bugzilla.gnome.org/show_bug.cgi?id=678828
Antoine Jacoutot [Mon, 9 Jul 2012 16:20:34 +0000 (18:20 +0200)]
OpenBSD: use G_N_ELEMENTS instead of nitems
nitems is never guaranteed to be defined in sys/params.h as it is meant
to be defined within a protected ifdef __KERNEL conditional.
Use G_N_ELEMENTS from GLib which is the proper way of doing this.
Benjamin Otte [Mon, 9 Jul 2012 01:11:01 +0000 (03:11 +0200)]
a11y: Make lockbutton notify about state changes
In particular, ensure that the name of the lockbutton gets updated as
the displayed text of the lockbutton changes.
https://bugzilla.gnome.org/show_bug.cgi?id=677347
Benjamin Otte [Mon, 9 Jul 2012 00:58:22 +0000 (02:58 +0200)]
a11y: Get lockbutton text directly
Instead of letting the generic button code attempt to find the currently
displayed text, just return the text directly.
https://bugzilla.gnome.org/show_bug.cgi?id=677347
Benjamin Otte [Mon, 9 Jul 2012 00:29:16 +0000 (02:29 +0200)]
a11y: Add separate accessible for GtkLockButton
The accessible doesn't do anything yet, this is just infrastructure
work.
Benjamin Otte [Sun, 8 Jul 2012 23:28:26 +0000 (01:28 +0200)]
a11y: Don't mess up if column gets hidden
We were using a function that insisted on visible columns for computing
the potential ID of an invisible column. Not good.
https://bugzilla.gnome.org/show_bug.cgi?id=675990
Cosimo Cecchi [Sun, 8 Jul 2012 04:27:30 +0000 (00:27 -0400)]
entry: guard for != NULL before unreffing the pixbuf
In gtk_entry_get_icon_pixbuf() we unreference the pixbuf that
_gtk_icon_helper_ensure_pixbuf() gives us back, since the function
doesn't return a reference, and by doing so we're able to return the
reference owned by the cached icon helper.
Since the icon helper method can return NULL though, if no icon
properties have been set on it, guard for != NULL before unreffing the
pixbuf, as that would cause a critical warning.
https://bugzilla.gnome.org/show_bug.cgi?id=679537
Cosimo Cecchi [Thu, 5 Jul 2012 14:49:39 +0000 (10:49 -0400)]
modelmenu: listen for toplevel changes on the attach widget
Right now, when we create a GtkModelMenu for a GMenuModel, we listen to
changes to the menu's attach-widget to detect when a toplevel
GtkApplicationWindow becomes available to fetch actions from it.
This unfortunately breaks this simple code:
GtkWidget *application_window = gtk_application_window_new();
GtkWidget *menu_button = gtk_menu_button_new();
GMenuModel *menu_model = get_menu_model();
gtk_menu_button_set_menu_model(menu_button, menu_model);
gtk_container_add(GTK_CONTAINER(application_window), menu_button);
Since GtkMenuButton creates a GtkModelMenu and sets itself as its attach
widget before it's added to a hierarchy containing a
GtkApplicationWindow.
Fix the bug by simply listening for changes in the window hierarchy, and
creating the menu model when the attach widget is added to an
application window.
https://bugzilla.gnome.org/show_bug.cgi?id=679454
Cosimo Cecchi [Thu, 5 Jul 2012 17:21:03 +0000 (13:21 -0400)]
menu: notify attach-widget property when menu is detached
When the menu is detached, the attach-widget property changes value to
NULL, so we should notify a property change, like
gtk_menu_attach_to_widget() does.
https://bugzilla.gnome.org/show_bug.cgi?id=679454
Cosimo Cecchi [Thu, 5 Jul 2012 20:40:23 +0000 (16:40 -0400)]
application: fix double free of app_id
This is fallout from commit
257b42e2f9d0759cc79967034f80c571c600faf3 -
those fields were already getting freed in
gtk_application_shutdown_x11() and my commit caused crashes on quit
instead.
Thanks to Rico Tzschichholz for reporting the bug and testing this fix.
Cosimo Cecchi [Fri, 29 Jun 2012 22:29:42 +0000 (18:29 -0400)]
modelmenu: set the accel group on the GtkMenu
Or the accelerators added for actions in the menu won't be displayed in
the menu items.
https://bugzilla.gnome.org/show_bug.cgi?id=679166
Cosimo Cecchi [Wed, 4 Jul 2012 19:41:55 +0000 (15:41 -0400)]
menubutton: set DROPDOWN_MENU hint on the menu toplevel
So the WM can render the menu shadows correctly, omitting the top side,
in the common case the menu is rendered down from a toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=679449
Cosimo Cecchi [Thu, 28 Jun 2012 22:09:33 +0000 (18:09 -0400)]
gtkstyle: add a gtkstyle-fallback style class for RC colors
As an addition to
10423726709539724be0ea19bed76ba4331af774, themes might
want to avoid using the hardcoded GTK defaults for legacy GtkStyle
values. Add a gtkstyle-fallback style class that can be used by themes
to tweak the legacy GtkStyle defaults.
https://bugzilla.gnome.org/show_bug.cgi?id=679092
Cosimo Cecchi [Mon, 2 Jul 2012 06:24:37 +0000 (02:24 -0400)]
application: plug some memory leaks
Cosimo Cecchi [Mon, 2 Jul 2012 06:19:06 +0000 (02:19 -0400)]
docs: fix a number of typos and obsolete references
Nguyễn Thái Ngọc Duy [Sat, 30 Jun 2012 02:42:01 +0000 (09:42 +0700)]
Updated Vietnamese translation
Nguyễn Thái Ngọc Duy [Sat, 30 Jun 2012 02:31:58 +0000 (09:31 +0700)]
po/vi: import from Damned Lies
Cosimo Cecchi [Fri, 29 Jun 2012 22:30:53 +0000 (18:30 -0400)]
menubutton: don't dereference NULL GdkEvent
Since we explictly call popup_menu with NULL when it's
keyboard-activated, we need to be careful and not access event->device
without checking for event != NULL before.
Cosimo Cecchi [Fri, 29 Jun 2012 20:54:10 +0000 (16:54 -0400)]
docs: add missing GtkApplication accelerator methods to doc sections
Ryan Lortie [Fri, 29 Jun 2012 03:55:33 +0000 (23:55 -0400)]
GActionMuxer: disconnect group signals on finalize
The signals for the action group were being disconnected when the action
group was explicitly removed from the GActionMuxer but the same was not
being done when it was finalized.
This means that a change in the state of an action group that used to be
associated with a finalized GActionMuxer would result in a crash. This
would happen for stateful application actions after closing a window.
Cosimo Cecchi [Thu, 28 Jun 2012 21:19:39 +0000 (17:19 -0400)]
docs: add gtk_ui_manager_add_ui_from_resource to gtk-doc
Or it won't show up in devhelp/online dev docs.
Alexander Larsson [Thu, 28 Jun 2012 19:30:24 +0000 (21:30 +0200)]
Handle transparent colors better in GtkStyle emulation
We can't expose colors with alpha in the GtkStyle colors, since
GdkColor has no alpha. Currently we throw away alpha completely,
which fails very badly for completely transparent backgrounds,
which now is the default for most widgets, as it typically
end up with black-on-black.
We handle this by falling back on the default/previous colors for
transparent colors. This is is simple and avoids complete failure.
https://bugzilla.gnome.org/show_bug.cgi?id=671437
Tom Tryfonidis [Thu, 28 Jun 2012 15:50:29 +0000 (18:50 +0300)]
Updated Greek translation
Alejandro Piñeiro [Mon, 25 Jun 2012 17:45:25 +0000 (19:45 +0200)]
a11y: remove implementation for [add/remove]_global_event_listener
Since release 2.5.3, ATK provides an implementation for those
methods, so toolkits doesn't need to implement them.
Sasi Bhushan Boddepalli [Wed, 27 Jun 2012 07:39:08 +0000 (13:09 +0530)]
Updated Telugu Translation
Alexander Shopov [Wed, 27 Jun 2012 04:14:05 +0000 (07:14 +0300)]
Updated Bulgarian translation
Colin Walters [Tue, 26 Jun 2012 13:41:33 +0000 (09:41 -0400)]
build: Drop --without-atk-bridge option
Instead, always build it if and only if X11. This reduces the set of
supported configurations.
https://bugzilla.gnome.org/show_bug.cgi?id=677491
Cosimo Cecchi [Tue, 26 Jun 2012 15:41:21 +0000 (11:41 -0400)]
widget-factory: add a symbolic icon column in the treeview example
Matthias Clasen [Mon, 25 Jun 2012 21:45:26 +0000 (17:45 -0400)]
Bump version
Matthias Clasen [Mon, 25 Jun 2012 21:20:17 +0000 (17:20 -0400)]
3.5.6
Matthias Clasen [Mon, 25 Jun 2012 20:26:41 +0000 (16:26 -0400)]
Don't export private GtkMountOperationHandler api
Matthias Clasen [Mon, 25 Jun 2012 19:01:14 +0000 (15:01 -0400)]
Updates for 3.5.6
Cosimo Cecchi [Wed, 30 May 2012 21:31:02 +0000 (17:31 -0400)]
radiobutton: add missing (element-type) annotation for radio groups
The GSLists should specify their element-type in every annotation. We
are missing some.
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Cosimo Cecchi [Wed, 30 May 2012 21:30:08 +0000 (17:30 -0400)]
menu: add missing (scope async) annotation to gtk_menu_popup()
Or the g-i scanner will emit a warning.
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Cosimo Cecchi [Wed, 30 May 2012 21:31:57 +0000 (17:31 -0400)]
widget: silence g-i scanner warning
The parameter should be named the same in the definition and the
declararion.
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Cosimo Cecchi [Wed, 30 May 2012 21:29:30 +0000 (17:29 -0400)]
fontchooser: silence g-i scanner warning
These parameters should be named the same in the definition and the
declaration.
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Cosimo Cecchi [Wed, 30 May 2012 21:28:06 +0000 (17:28 -0400)]
actionable: silence g-i scanner warning
The parameter should be named the same in the definition and the
declararion.
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Cosimo Cecchi [Wed, 30 May 2012 21:12:04 +0000 (17:12 -0400)]
application: fix a typo in introspection annotation
https://bugzilla.gnome.org/show_bug.cgi?id=677127
Chun-wei Fan [Tue, 15 May 2012 08:16:25 +0000 (16:16 +0800)]
Bug 676077: Fix handling of Keyboard Input on Windows
Don't use ASCII control characters to denote the input of Esc, Tab,
Return/Enter, Backspace and Delete, as it seems that it is not how
Windows handle them, and they cause weird characters to appear in the
input field on GTK+3 programs in non-English Windows. Instead, let
these keys be handled as-is on Windows, like what is done in GTK+-2.x.
Checked with mclasen on IRC, and thanks to the people who verified the
patch to not break anything on English Windows.
Alexander Larsson [Mon, 25 Jun 2012 13:00:42 +0000 (15:00 +0200)]
Rename gtk_icon_view_get_cell_area to gtk_icon_view_get_cell_rect
get_cell_area was "conflicting" with the property named "cell-area"
which is something different.
Fran Diéguez [Sun, 24 Jun 2012 21:57:58 +0000 (23:57 +0200)]
Updated Galician translations
John Ralls [Sun, 24 Jun 2012 11:36:51 +0000 (12:36 +0100)]
Enable gio-unix for Quartz
Fixes a compile failure because gdbus-config uses G_OS_UNIX to guard
gio-unix features instead of HAVE_GIO_UNIX.
Matthias Clasen [Sat, 23 Jun 2012 17:08:03 +0000 (13:08 -0400)]
Cosmetics
Matthias Clasen [Sat, 23 Jun 2012 17:07:47 +0000 (13:07 -0400)]
Fix a compiler warning
This was introduced in the previous commit.
Matthias Clasen [Sat, 23 Jun 2012 16:20:54 +0000 (12:20 -0400)]
GtkNotebook: Fix reverse tab order
When using Shift-Tab to move the focus out of page content onto
the tab label, we end up in a situation where both Tab and Shift-Tab
move focus back into the page, which is not really what is expected
when the notebook is part of a dialog.
Instead, arrange things so that using Shift-Tab with focus on a
tab label moves the focus out of the notebook.
http://bugzilla.gnome.org/show_bug.cgi?id=669986
Colin Walters [Sat, 23 Jun 2012 16:19:06 +0000 (12:19 -0400)]
gtkdbusinterfaces: Fix srcdir != builddir
Rico Tzschichholz [Sat, 23 Jun 2012 15:48:27 +0000 (17:48 +0200)]
gtk: add gtkdbusinterfaces.xml to EXTRA_DIST
Matthias Clasen [Sat, 23 Jun 2012 13:59:10 +0000 (09:59 -0400)]
GtkNotebook: Maintain invariants during tab dnd
It turns out that we can end up removing a notebook child while
the tab is still 'detached'. Child removal causes
gtk_notebook_remove_tab_label() to be called on the tab label,
but that function did not deal with the eventuality that the tab
label may be a child of the dnd window.
http://bugzilla.gnome.org/show_bug.cgi?id=677943
Chun-wei Fan [Sat, 23 Jun 2012 04:59:51 +0000 (12:59 +0800)]
config.h.win32.in: Updates
Make it reflect the contents of the config.h.in template.
Chun-wei Fan [Sat, 23 Jun 2012 04:48:32 +0000 (12:48 +0800)]
gtk/gtkcsseasevalue.c: Remove C99ism
Chun-wei Fan [Sat, 23 Jun 2012 04:47:31 +0000 (12:47 +0800)]
Update Visual C++ property sheets
"Install" the demo css files as well.
Chun-wei Fan [Sat, 23 Jun 2012 04:46:54 +0000 (12:46 +0800)]
Fix the gtk3-demo Visual C++ projects
Add the demos that were introduced recently in the projects.
Chun-wei Fan [Sat, 23 Jun 2012 04:15:59 +0000 (12:15 +0800)]
gtk/Makefile.am: Fix Visual C++ disthook rules
gtkdbusgenerated.c needs to be included in the projects as well.
Chun-wei Fan [Sat, 23 Jun 2012 04:14:35 +0000 (12:14 +0800)]
Update Visual C++ 2008 property sheet
Standardize on using $(CopyDir), as it is now done in the Visual C++ 2010
sheets, for consistency reasons.
Colin Walters [Fri, 22 Jun 2012 17:29:03 +0000 (13:29 -0400)]
build: Add --without-atk-bridge, only check for it on X11 platforms
Some builders using gtk3 outside of the GNOME cycle want an option to
avoid linking to atk-bridge-2.0. Provide that, and at the same time
ensure we're only looking for it on X11 platforms.
https://bugzilla.gnome.org/show_bug.cgi?id=677491
Cosimo Cecchi [Thu, 21 Jun 2012 01:36:09 +0000 (21:36 -0400)]
mountoperation: use the Shell DBus proxy if available
Make GMountOperation look for an owner of org.Gtk.MountOperationHandler
if possible, and use it instead of the GTK-based dialogs.
This allows applications to use the implementation offered by the
desktop shell, if available, through a DBus private interface:
org.Gtk.MountOperationHandler.
https://bugzilla.gnome.org/show_bug.cgi?id=674963
Alexander Larsson [Tue, 19 Jun 2012 16:58:13 +0000 (18:58 +0200)]
Add gtk_icon_view_get_cell_area
This gets the current cell area of a particular item. Its similar
to gtk_tree_view_get_cell_area().
The code is extracted from gtk_icon_view_set_tooltip_cell which now
just calls the old code.
https://bugzilla.gnome.org/show_bug.cgi?id=678418
Shankar Prasad [Fri, 22 Jun 2012 10:54:29 +0000 (16:24 +0530)]
Fixed the issue reported in Bug #613561
Matthias Clasen [Wed, 20 Jun 2012 11:46:04 +0000 (07:46 -0400)]
GdkDevice: Fix an inverted assertion
gdk_device_list_slave_devices only makes sense to call on master
devices, yet its g_return_if_fail check made it reject such devices.
Pointed out by monty.
Matthias Clasen [Fri, 15 Jun 2012 21:38:15 +0000 (17:38 -0400)]
a11y tests: update expected results
Sasi Bhushan Boddepalli [Wed, 20 Jun 2012 13:52:25 +0000 (19:22 +0530)]
Updated Telugu Translation
Dan Vrátil [Wed, 20 Jun 2012 06:26:14 +0000 (08:26 +0200)]
Fix a memory leak in GtkImage
https://bugzilla.gnome.org/show_bug.cgi?id=678175
Daniel Mustieles [Tue, 19 Jun 2012 15:07:09 +0000 (17:07 +0200)]
Updated Spanish translation
Pavel Holejsovsky [Tue, 19 Jun 2012 12:35:57 +0000 (14:35 +0200)]
GtkImage: fix get_property('stock')
The code was trying to get icon's name instead of icon's stock-id.
https://bugzilla.gnome.org/show_bug.cgi?id=678407
Руслан Ижбулатов [Sat, 12 May 2012 16:29:13 +0000 (20:29 +0400)]
Fix windres invocation
Signed-off-by: Chun-wei Fan <fanchunwei@src.gnome.org>
Benjamin Otte [Mon, 18 Jun 2012 14:28:52 +0000 (10:28 -0400)]
widget: don't call gtk_style_context_set_background if app_paintable
When a widget is app_paintable, its background should not be drawn by
the theme, thus we should not try to override its background again when
style-updated is fired.
This is a bit of a hack, but it fixes gray surfaces observed for DnD
windows with recent GTK+.
Khaled Hosny [Sun, 17 Jun 2012 11:46:28 +0000 (13:46 +0200)]
Updated Arabic translation
Piotr Drąg [Fri, 15 Jun 2012 21:33:23 +0000 (23:33 +0200)]
Updated POTFILES.in
Bastien Nocera [Wed, 30 May 2012 16:45:39 +0000 (17:45 +0100)]
gtkmenutoolbutton: Use GtkMenuButton
To implement the drop-down menu.
https://bugzilla.gnome.org/show_bug.cgi?id=668013
Bastien Nocera [Tue, 29 May 2012 17:39:37 +0000 (18:39 +0100)]
gtkmenubutton: Add menu button widget
As used in Totem and gnome-contacts. The widget
takes either a GtkMenu or a GMenuModel to construct
its menu, and can be given a parent widget to use to
position the drop-down (as used in GtkMenuToolButton).
https://bugzilla.gnome.org/show_bug.cgi?id=668013
Bastien Nocera [Wed, 13 Jun 2012 18:45:21 +0000 (19:45 +0100)]
gtk: Always load the atk-bridge
Slightly modified by Alejandro Piñeiro
https://bugzilla.gnome.org/show_bug.cgi?id=677491
Benjamin Otte [Fri, 15 Jun 2012 01:30:52 +0000 (03:30 +0200)]
image: Don't add border twice
Failed to delete these lines in
d40c496e6eacb9f95c2b27eaebf58d320c2b9387
Benjamin Otte [Fri, 15 Jun 2012 00:48:24 +0000 (02:48 +0200)]
reftests: Add a reftest for the empty iconview
Benjamin Otte [Fri, 15 Jun 2012 00:44:45 +0000 (02:44 +0200)]
iconview: Special case the empty iconview
If the icon view is empty, we cannot get a reasonable size request from
the cell renderers. So all values we would compute are pretty much
useless.
So we special case it.
This also gets rid of a bunch of crashers from div-by-0 in corner cases.
https://bugzilla.gnome.org/show_bug.cgi?id=677809
Benjamin Otte [Thu, 14 Jun 2012 18:06:39 +0000 (20:06 +0200)]
image: background and border should be drawn around the widget
... not around the contents. If you want the widget to not be larger
than the contents, don't use ALIGN_FILL.
Benjamin Otte [Thu, 14 Jun 2012 16:52:09 +0000 (18:52 +0200)]
iconview: Add a descriptive function
I want to special-case empty icon views in the sizing code to avoid
various bugs, and having such a function is nice.
Benjamin Otte [Thu, 14 Jun 2012 16:44:06 +0000 (18:44 +0200)]
iconview: Ensure icons are at least 1x1 pixels
This is useful for 2 reasons:
(1) Items actually exist and are clickable
(2) Size computations don't divide by 0
I've not seen problems with this in the wild (mostly because
item-padding defaults to non-0), but noticed this while fixing other
bugs.
Benjamin Otte [Thu, 14 Jun 2012 05:35:15 +0000 (07:35 +0200)]
iconview: Don't add item-padding
... to item sizes when there are no items.